Skip to content

Community help center - send delete task even document doesn't exist#563

Merged
epipav merged 2 commits into
mainfrom
bugfix/chc-send-delete-task-even-doc-not-exists
Feb 22, 2023
Merged

Community help center - send delete task even document doesn't exist#563
epipav merged 2 commits into
mainfrom
bugfix/chc-send-delete-task-even-doc-not-exists

Conversation

@epipav
Copy link
Copy Markdown
Collaborator

@epipav epipav commented Feb 22, 2023

Changes proposed ✍️

  • We were finding the document first and were sending the delete request if it existed. This was causing sync problems between the search engine and database in some edge cases when using the auto-publishing feature.
  • Now we send the delete request even if the document does not exist.

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@epipav epipav requested a review from joanreyero February 22, 2023 17:09
@epipav epipav self-assigned this Feb 22, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Feb 22, 2023
@epipav epipav marked this pull request as ready for review February 22, 2023 17:10
@epipav epipav changed the title Community help center - Send delete task even document doesn't exist Community help center - send delete task even document doesn't exist Feb 22, 2023
@epipav epipav merged commit bc61b2f into main Feb 22, 2023
@epipav epipav deleted the bugfix/chc-send-delete-task-even-doc-not-exists branch February 22, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants